Open
Conversation
anfelbar
reviewed
Jun 19, 2025
| ], | ||
| exec_properties = { | ||
| "container-image": "docker://645088952840.dkr.ecr.eu-west-1.amazonaws.com/engflow-re/windows-x64:engflow_worker@sha256:6a53c6d5cbc82ca0782e9117482e457a676920227b697de5db90ff53e7afedbe", | ||
| "container-image": "<YOUR_WINDOWS_CONTAINER_IMAGE_URI>", |
Collaborator
There was a problem hiding this comment.
Is this because of security reasons?
Collaborator
There was a problem hiding this comment.
Oh wait. It looks like we don't run against windows (I think we did before)
Contributor
There was a problem hiding this comment.
Please keep this: it's not an example, it's meant to be used in production, even if we're not doing that right now.
anfelbar
approved these changes
Jun 19, 2025
jayconrod
reviewed
Jun 20, 2025
| ], | ||
| exec_properties = { | ||
| "container-image": "docker://645088952840.dkr.ecr.eu-west-1.amazonaws.com/engflow-re/windows-x64:engflow_worker@sha256:6a53c6d5cbc82ca0782e9117482e457a676920227b697de5db90ff53e7afedbe", | ||
| "container-image": "<YOUR_WINDOWS_CONTAINER_IMAGE_URI>", |
Contributor
There was a problem hiding this comment.
Please keep this: it's not an example, it's meant to be used in production, even if we're not doing that right now.
Contributor
There was a problem hiding this comment.
This is based on an internal script docker_build.ps1. Let's keep these in sync. Please update that one first and verify docker build works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
trap {}statement by changing it to atry...catch$repoRootDir = Get-Locationwas invoked, the error would get masked by another error from within thetraphandler